Skip to content

fix temperature calculation #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 20, 2022
Merged

fix temperature calculation #55

merged 1 commit into from
Mar 20, 2022

Conversation

jerryneedell
Copy link
Contributor

fixes #54
Tested with lsm6dsox and lsm6ds33 on QTPy_esp32s2
Yields much more reasonable temperatures than the current implementation.

@jerryneedell jerryneedell requested a review from a team March 20, 2022 13:41
tekktrik
tekktrik approved these changes Mar 20, 2022
View reviewed changes
Copy link
Member

@tekktrik tekktrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Didn't test myself, but definitely seems to agree with the datasheet much more like you say. Thanks!

FoamyGuy
FoamyGuy approved these changes Mar 20, 2022
View reviewed changes
Copy link
Contributor

@FoamyGuy FoamyGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested successfully with LSM6DS33. Temperature values do look much more accurate in my case as well. Was showing negative values with current implementation and roughly room temp with these changes.

@FoamyGuy FoamyGuy merged commit 98653ee into adafruit:main Mar 20, 2022
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Mar 21, 2022
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@8ce3914)
8e3415b 
Updating https://github.com/adafruit/Adafruit_CircuitPython_LSM6DS to 4.4.2 from 4.4.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_LSM6DS#55 from jerryneedell/jerryn_temperature
  > Merge pull request adafruit/Adafruit_CircuitPython_LSM6DS#53 from infamy/main

Updating https://github.com/adafruit/Adafruit_CircuitPython_ST7565 to 1.1.0 from 1.0.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_ST7565#4 from U47/patch
  > Fixed readthedocs build
  > Consolidate Documentation sections of README

Updating https://github.com/adafruit/Adafruit_CircuitPython_ST7789 to 1.5.7 from 1.5.6:
  > Merge pull request adafruit/Adafruit_CircuitPython_ST7789#31 from makermelissa/master
@jerryneedell jerryneedell deleted the jerryn_temperature branch March 21, 2022 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FoamyGuy FoamyGuy FoamyGuy approved these changes

@tekktrik tekktrik tekktrik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect temperature calculation
3 participants
@jerryneedell @FoamyGuy @tekktrik